Fixes for Recent Google requirements changes #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muratiakos Thanks for updating this! Apologies for looking at this after a.... while! Changes look reasonable, so I'm happy to approve it, but I think it needs to be updated yet again, since it hasn't been maintained for a while :) |
AshWave
approved these changes
Oct 11, 2024
Thanks @AshWave ! I have updated the PR and bumped the versions and dependecies too. Feel free to test and merge if you are happy with these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the key dependencies to meet recent requirement changes from Google Play store to accept new applications based on https://developer.android.com/google/play/requirements/target-sdk and also fixes some broken links. The changes are namely:
The changes were tested successfully on the official Volvo XC40 VD:
Other possible updates and refactoring were intentionally not been made to keep the change-set small and focused on original functionality.
[email protected] , @AshWave - Thanks for this code and considering my changes as part of your your review.